Keep in store locale, country and currency #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeina-idris
approved these changes
Aug 29, 2019
|
I guess this fixes issue #147 ? |
plaskevich
approved these changes
Aug 29, 2019
|
@zeina-idris @plaskevich I have fixed the tests, please check the change as they are not trivial. |
zeina-idris
approved these changes
Aug 31, 2019
Not completely. This PR only allows to configure country/currency/languages. What the issue mentions is that we should fetch this information from the API, and fallback to the configured ones when it's not available. So let's say this PR does 25% of the issue :P |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vuex-persistedstateto keep in local storage the authentication, as well as country/language/currency.